Growing up in Vancouver, David was first was exposed to the world of professional music at the age of twelve. As a teenager, he was part of many bands and played locally regularly, moving from one playing situation to another, refining his guitar skills and performance. At the expense of his academic courses at the University of British Columbia's School of Music (Canada), he would often spend hours in the music library listening to a wide variety of guitar music from delta blues, to Django and to classical. During that period he was also introduced to the recording studio namely, "Vancouver Recording" (with legendary Vancouver engineer/producer Robin Spurgin), one of the very few pro studios in town at the time, which he frequented for days at a time, observing sessions and doing everything and anything he could to gain "studio" experience.

By the age of 18, he was already a professional musician performing 5 to 6 nights a week in some of Vancouver's notorious 'East -end' cabarets, and appeared regularly as a feature vocalist on CBC TV's 'Let's Go' and 'Where it's At' series. He also performed as a solo acoustic artist at coffeehouses and toured B.C. as opening act for 'The Poppy Family'. Over the next few years he released his first solo album, Take My Hand, and helped form the successful Vancouver group "Sunshyne" which included the late Bruce Fairbairn (producer for Aerosmith etc), Jim Vallance (songwriter with Bryan Adams and Ozzy Osborne) and jazz flautist/saxophonist Tom Keenleyside. Sinclair left "Sunshyne" after a few years to tour with a succession of major Canadian artists. Meanwhile, "Sunshyne" was transformed into "Prism", and David played some guitar on their first 3 albums.

As well as becoming a top-call studio player, doing a myriad of jingles, TV shows, films and records, he started working with arranger/composer/studio musician Bob Buckley, with whom he would form the bands 'Straight Lines' and 'Body Electric'. "Straight Lines" climbed the radio charts with Roanne, Heads are gonna roll, Letting Go (Juno nominee-best songwriters, top 10 across Canada, Billboard pick), to name a few. Body Electric's "Do You Think They Can Tell" was given an "Outstanding Airplay" award in 1984. As well as their own shows, these bands toured with top National and International artists such as Corey Hart, Joan Armatrading, Loverboy, and Parachute Club, to name a few.

From 1992 to 1995, David toured with k.d. lang, and joined Sarah McLachlan's band from 1993 to 2003, touring extensively in North America, Europe, and Japan and appearing (with both artists) on shows including Jay Leno, David Letterman, Conan O'Brien, Arsenio Hall, Saturday Night Live, Larry Sanders, Good Morning America, Rosie O'Donnell, MTV Unplugged, VH1 Storytellers, The Grammy Awards Show, and the Juno Awards.

As a studio guitarist, he has worked with many Canadian artists including Sarah McLachlan, Michael Buble, Daniel Powter, Bachman Turner Overdrive, Bryan Adams, Amy Sky, Rita MacNeil, Paul Janz, Valdy, Susan Jacks, Terry Jacks, Barry Greenfield, Prism, Irish Rovers, Matthew Lien, Gary Fjellgaard and many more. He has played on and composed music for many TV series and films, appeared on numerous occasions with the Vancouver Symphony Orchestra and a variety of musical theatre productions.

He currently performs with the David Sinclair & Keith Bennett duo; Holly Arntzen & Kevin Wright (aka The Wilds), Jane Mortifee, Susan Jacks, Melanie Dekker, Kent Fiddy & David Sinclair duo,, and many more. He has two instrumental acoustic guitar CDs, Acoustic Christmas, which received top 5 all-time Christmas Favorites ratings in the Vancouver Province, and has been included in compilations and several TV scores, and No Words, a collection of originals and arrangements of traditional Celtic pieces. Other releases include David Sinclair & Keith Bennett 'Alchemy' (2012) and 'TWO' (2018) , featuring acoustic guitar and harmonica, instrumental and vocal; Kent Fiddy & David Sinclair- 'The Way It Oughta Be', a collaboration with songwriter Kent Fiddy; the re-release on CD of his first solo recording , 'Take My Hand' on Regenerator Records, 'Strange Paradise' (2015), a mix of original instrumental and vocal tunes, and 'Grandma's Shoes' (2018) by Christine Domeij Sinclair and David Sinclair.